[Libreoffice] .: 2 commits - vcl/inc vcl/source writerfilter/inc writerfilter/source

Miklos Vajna vmiklos at frugalware.org
Wed Dec 21 16:50:59 PST 2011


Hi August,

On Mon, Dec 19, 2011 at 08:11:42PM -0800, August   Sodora <augsod at kemper.freedesktop.org> wrote:
>  vcl/inc/vcl/field.hxx                           |    9 --
>  vcl/source/control/field2.cxx                   |   92 ------------------------
>  writerfilter/inc/resourcemodel/TagLogger.hxx    |    5 -
>  writerfilter/source/resourcemodel/TagLogger.cxx |   53 -------------
>  4 files changed, 159 deletions(-)

Please avoid such commits in the future, what you removed are methods
necessary for the XML dump writerfilter creates when built using
dbglevel=2.

I've fixed it with commit acfdec468d54d44f94ca6752bbbfbdab07ef9a0c - in
fact the best is to properly find the user of the method, see how it is
defined (DEBUG_DOMAINMAPPER, DEBUG_RESOLVE, etc) and add ifdef guards
around those "unused" methods.

Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111222/cb2a5c81/attachment.pgp>


More information about the LibreOffice mailing list