[Libreoffice] [REVIEW 3-4-5] untranslated menu items

Andras Timar timar74 at gmail.com
Fri Dec 23 07:47:24 PST 2011


2011/12/23 Petr Mladek <pmladek at suse.cz>:
> David Tardon píše v Čt 22. 12. 2011 v 15:16 +0100:
>> Hi all,
>>
>> commit 7248aaed7aca6c241683f6d83bb6caa00c447b0d reverts earlier commit,
>> that caused some menu items to be left untranslated. If you are
>> wondering why it is so, read my comment (I hope it is understandable) in
>> commit a6511b9d9a3f13835510a9caffc837829b206d14 :-)
>>
>> How to reproduce:
>> 1. start writer in your favorite locale
>> 2. select View->Data Sources from menu
>> 3. open a table
>> 4. right click on a cell. A popup menu with just one item--Copy--is
>>    opened. The item is not translated.
>
> It makes perfect sense and builds here. I guess that the original
> modification solved a build problem but it was not the correct solution.
>
> I have pushed it to libreoffice-3-4 branch, see
> http://cgit.freedesktop.org/libreoffice/libs-core/commit/?h=libreoffice-3-4&id=fd24f1c0bb271d8e5aa36e6ac39e6f435976b90f
>
> We need two more approvals for the 3-4-5 branch. It would be great if
> Fridrich or Andras might double check build on Windows.
>

It builds on Windows (I tried only incremental build) and I confirm
that the issue is fixed. +1 from me.

Best regards,
Andras


More information about the LibreOffice mailing list