[Libreoffice] [PUSHED][PATCH] Fix for fdo43460 Part XIV getLength() to isEmpty()

Ivan Timofeev timofeev.i.s at gmail.com
Fri Dec 23 10:13:38 PST 2011

Hi Gustavo,

23.12.2011 21:21, Gustavo Pacheco пишет:
> Hi!
> Partial fix for Easy Hack FDO43460 (part XIV) for review. Mentoring by
> Olivier Hallot (thanks for the tips Olivier!).
> Part XVI
> Modules drawinglayer, dtrans and editeng

Looks nice for me, but

-            if (aLocale.Language.getLength() || 
+            if (!(aLocale.Language.isEmpty() || aLocale.Country.isEmpty()))

is wrong - (!A || !B) => !(A && B), but since I personally don't like 
negators outside a compound condition, I changed it to the first variant.

Pushed to master:

Thank you Gustavo, thank you Olivier!


More information about the LibreOffice mailing list