[Libreoffice] [PATCH 1/8] Easyhack fdo#38831 remove SvStrings
Brad Sowden
code at sowden.org
Thu Dec 29 01:25:11 PST 2011
Hi,
See attached.
Note 1
------
I assume casting from size_t to sal_uInt16 is reasonable in the
following scenario (I didn't want to update all callers in this patch)?
sal_uInt16 SwGlossaries::GetGroupCnt()
{
- return GetNameList()->Count();
+ return static_cast<sal_uInt16>(GetNameList()->size());
}
Note 2
------
In 2 functions I made the following change. Is this ok or should I also
call reserve(16) to be safe?
- SvStrings aFiles( 16, 16 );
+ std::vector<String*> aFiles;
Regards,
Brad
More information about the LibreOffice
mailing list