[Libreoffice] [REVIEW] quick patch for extensions ole part

julien2412 serval2412 at yahoo.fr
Thu Dec 29 08:38:31 PST 2011


Another "Same expression on both sides of '||'"
 detected by cppcheck.

I supposed this patch but I made a research of "INVOKE_PROPERTYPUT" on the
file, either it's not the only location where INVOKE_PROPERTYPUTREF should
be used or INVOKE_PROPERTYPUTREF shouldn't be used at all in this case.

diff --git a/extensions/source/ole/oleobjw.cxx
index 8fb9261..9d203c8 100644
--- a/extensions/source/ole/oleobjw.cxx
+++ b/extensions/source/ole/oleobjw.cxx
@@ -1814,7 +1814,7 @@ Any 
IUnknownWrapper_Impl::invokeWithDispIdComTlb(FuncDesc& aFuncDesc,
     if (dispparams.cNamedArgs > 0 &&
         ! (dispparams.cNamedArgs == 1 &&
            (aFuncDesc->invkind == INVOKE_PROPERTYPUT ||
-            aFuncDesc->invkind == INVOKE_PROPERTYPUT)))
+            aFuncDesc->invkind == INVOKE_PROPERTYPUTREF)))
         //set up an array containing the member and parameter names
         //which is then used in ITypeInfo::GetIDsOfNames

Any idea ?


View this message in context: http://nabble.documentfoundation.org/REVIEW-quick-patch-for-extensions-ole-part-tp3619208p3619208.html
Sent from the Dev mailing list archive at Nabble.com.

More information about the LibreOffice mailing list