[Libreoffice] [PUSHED] Re: [PATCH] fix EasyHack FDO42454, remove code associated with unused icons

Jan Holesovsky kendy at suse.cz
Thu Dec 29 11:28:39 PST 2011

Hi Gustavo,

On 2011-12-20 at 16:19 -0200, Gustavo Pacheco wrote:

> Fix for EasyHack FDO42454
> (https://bugs.freedesktop.org/show_bug.cgi?id=42454) in attachment for
> review.

Thank you very much for the patch! :-) - and sorry that it took so long
to apply.  I used most of that, please see:


> But only list.png, galimpl.png, galimps.png were referenced in the
> code:
> fpicker/res/list.png: list.bmp (removed
> from /fpicker/source/office/iodlg.src in the patch)

Here I actually removed a bit more, the entire ImageButton was
referenced nowhere, so I removed it for good.

> svx/res/galimps.png: galimps.bmp (removed from
> svx/source/gallery2/gallery.src in the patch)
> svx/res/galimpl.png: galimpl.bmp (removed from
> cui/source/dialogs/gallery.src in the patch)

But I did not touch these (ie. did not use this part of your patch).
There is something more rotten going on - as you can see, the images
in .src use .bmp (!) suffix, not .png, so I suspect there is even more
unused code there, probably.

Can you please try track where is the code that is supposed to use
these .src files, and if it works at all?

Thank you,

More information about the LibreOffice mailing list