[Libreoffice] solenv/inc/settings.mk overwrites CDEFS

[Norbert Thiebaud]

On Tue, Feb 1, 2011 at 5:05 PM, Thomas Arnhold <thomas at arnhold.org> wrote:
> Hi,
>
> I just found out, that settings.mk resets all CDEFS which were defined
> in some makefiles. For example:
>
> sc/source/ui/vba/makefile.mk defines:
>
> CDEFS+=-DVBA_OOBUILD_HACK
>
> But some lines later settings.mk is included (which is
> solenv/inc/settings.mk)
>
> .INCLUDE :  settings.mk
>
> In this file CDEFS is reset. So VBA_OOBUILD_HACK doesn't get defined for
> sc/source/ui/vba. Is this intended or a bug?

based on the other 2 uses of VBA_OOBUILD_HACK, I'd imagine that the
CDEF should be _after_ the include setting.mk

Norbert

>
> -Thomas
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>