[Libreoffice] [PATCH] removed more blank lines/reordered #include's

Caolán McNamara caolanm at redhat.com
Tue Feb 8 05:55:06 PST 2011

On Mon, 2011-02-07 at 08:54 +0100, Christina Roßmanith wrote:
> There are at least three different stlpool.hxx in different directories 
> of LO, but 

> it is included just as "#include <stlpool.hxx>". I think that 
> ../../../../inc/bf_sd/stlpool.hxx is the one which is included, but I am 
> not sure. Shouldn't the line be changed to "#include 
> <bf_sd/stlpool.hxx>" then?

if you...

export VERBOSE=true
and run dmake in that dir you'll see the exact compiler line used, and
it has -I../../../../inc/bf_sd near the start. So that's the first place
that gets looked so yeah, that's the one that gets included. If you want
to change it for consistently reasons then go ahead, though I wouldn't
expend much energy in binfilter for the usual reasons around binfilter.

No objections to the patch, go ahead and push it IMO.


More information about the LibreOffice mailing list