[Libreoffice] which bugids to keep (was: [PUSHED] patch lib-core/eventattacher)

[Thorsten Behrens]

Cedric Bosdonnat wrote:
> On Tue, 2011-02-08 at 21:04 +0100, Christina Roßmanith wrote:
> > there were more patches not yet pushed, so I've applied them. I didn't 
> > touch the files which differed only by whitespace. And I didn't delete 
> > comments containing bugids and text. This I would like to leave for the 
> > experts  :-)
> 
> You were right not to delete those comments entirely... they can be
> useful.
> 
Yep - though in general, these '#123456#' bug ids can be elided -
the usually-followed convention is, that those are bugids of
StarDivision's old internal bugtracking system (and '#b123456#' the
ones from Sun's internal bugtracker) - so they're of no value to the
general public. Public OOo bugs are usually marked as '#i12345#' -
still worth checking though via

http://qa.openoffice.org/issues/show_bug.cgi?id=<bugid>

whether just by chance someone forgot to add the 'i'.

So in this case, it would have been ok to remove the bugid, but
leave the rest of the (quite useful) comment.

Cheers,

-- Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110209/a5d20146/attachment-0001.pgp>