[Libreoffice] [REVIEW] RTF unicode export - need patch review for -3-3

Caolán McNamara caolanm at redhat.com
Fri Feb 11 08:57:57 PST 2011

On Fri, 2011-02-11 at 17:35 +0100, Miklos Vajna wrote:
> Hi,
> This commit in master:
> http://cgit.freedesktop.org/libreoffice/writer/commit/?id=a37fae128b4badc8f9f2201e28dca3e08948ddec
> Fixes:
> https://bugs.freedesktop.org/show_bug.cgi?id=33653
> Could someone familiar with that code (Cedric, Caolan?) sign it off and
> cherry-pick, please?

Done for 3-3, not for 3-3-1 though, that needs more acks.

Background for other readers is that in the binary filters we can write
the font table *after* we have traversed all the text. For a Word 6/Word
95 document we can then convert out-of-ascii range unicode to whatever
8bit msXXXX encoding they fit into and add a font to the font table and
mark it as using that encoding in order to munge out-of-range unicode
into these 8bit only formats.

For rtf however if we wanted to do that, in order to use 8bit encodings
for text we'd need to either parse the document twice, or write to
document body some temp file and stick the font header on afterwards. Or
forget about it and just use the rtf unicode encoding mechanisms.

In master the method now also has a sane name of
"DestFileFormatSupportsUnicode" or something like that.


More information about the LibreOffice mailing list