[Libreoffice] [PUSHED] Re: [PATCH] Some build breakage fixes for MSVC2008

Fridrich Strba fridrich.strba at bluewin.ch
Sat Feb 12 05:17:38 PST 2011

Hello, Steven,

Sorry, I pushed my fixes before reading your e-mail :(

On Sat, 2011-02-12 at 20:54 +1000, Steven Butler wrote:
> I didn't want to break anything so I took an easy out and made it
> mutable but I would think it would be better fixed by using const_cast
> wherever a non-const iterator is created.

I think I came with a solution that does not need casts. Use
const_iterators whenever a non const ones are not needed. It compiles
and the unit tests run.

> unopkg_app_stl_fix.patch fixes apparent breakage in the use of fill_n
> - my reference says it returns void but the original code was
> expecting an iterator returned.  I imagine it must be an STLport
> extension, but it is broken with the built in STL and I believe the
> fix is correct.

I took your fix, because my fix from last night was flawed, thanks for

Thanks for your precious work. BTW, do the smoketests run for you? Here
they run, but there is a crash on exit :(



More information about the LibreOffice mailing list