[Libreoffice] [PATCH] fix for i#115716 & fdo#33964

Caolán McNamara caolanm at redhat.com
Tue Feb 15 04:01:32 PST 2011

On Mon, 2011-02-14 at 20:08 +0000, Noel Power wrote:
> (reposting with [PATCH] keyword
> although the fix for this issue will appear from dev300m98 onwards it 
> would be worth I think getting this into
>   a) libreoffice-3-3 ( one ack please )
> and possibly
>   b) libreoffice-3.3.1 ( 3 acks please )
> I only mention 3.3.1 because there is a request in the bug to make 
> oracle office 3.3.1. The patch is trivial and imho non-risky

Is it guaranteed that str is NULL terminated, i.e. getStr() has always
claimed that it might not actually be NULL terminated, and this assumes
a NULL terminator exists and can be pushed into blob.
e.g. str of "a" and
insert(blob->begin(), str.getStr(), str.getStr() + str.getLength() + 1)
will insert range [*str, *(str+2)) i.e. *str and *(str+1)
could just shove push_back(0) in there instead.


More information about the LibreOffice mailing list