[Libreoffice] [PATCH] fix for i#115716 & fdo#33964

Michael Meeks michael.meeks at novell.com
Tue Feb 15 07:28:15 PST 2011

On Tue, 2011-02-15 at 15:04 +0000, Caolán McNamara wrote:
> Yes, ::insert don't dereference the final end iterator, but it does use

	Hah - quite right ;-) I only got past the double bluff to get suckered
at the next fence; so this is duff; we should append getLength() and
then push_back a '\0' if we need it. There is no '\0' terminator in
OStrings, though - apparently often by accident there is one there ;-)

> The original problem to be fixed is a lack of a zero terminator in the
> *output* blob, its just an issue of copying it from the original string
> or adding a new one, just making sure that if we go with copying it from
> the original string, that the original string has one ;-)

	Which it doesn't, so good catch; Noel we should fix that :-)



 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list