[Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc

Caolán McNamara caolanm at redhat.com
Thu Feb 24 07:30:45 PST 2011

On Thu, 2011-02-24 at 10:11 -0500, Kohei Yoshida wrote:
> On Thu, 2011-02-24 at 15:26 +0100, Julien Nabet wrote:
> > 2) must we remove all the "rtl::" stuff ?
> If you mean "using namespace rtl;", yes, because that could cause
> conflict between com::sun::star::uno::Reference and rtl::Reference.  I
> prefer we don't have any of those lines in our code base.

Just to clarify here, and looking at the patch. The goal is to remove
"using namespace rtl;", right ?
not to remove rtl:: off the front of everything.
i.e. in the attached patch I see 

-using namespace rtl;

which looks fine, 
and I see various

+using ::rtl::OUString

which looks fine when necessary to make it possible to compile a file
which used to have "using namespace rtl;" and uses bare "OUString"
without making vast amounts of changes.

but I see some


which would be unnecessary, and likely cause a huge amount of churn,
no ?


More information about the LibreOffice mailing list