[Libreoffice] [PATCH] Fix replacement of $filename$ in GTK SaveAs dialogs

Kevin Hunter hunteke at earlham.edu
Thu Feb 24 11:30:15 PST 2011

At 11:30am -0500 Thu, 24 Feb 2011, Caolán Mcnamara wrote:
> On Thu, 2011-02-24 at 09:57 -0500, Kevin Hunter wrote:
>> please do spit it back to me with, "you should implement it this
>> way instead"

> c) I wouldn't bother with the aFileObj.HasError() and return 0, i.e.
> I'd prefer to get some mangled/empty string as the filename listed in
> the overwrite dialog, rather than returning out of the whole method
> on failure

Interesting.  From a different background, I worry about _all_ input.  I 
don't know the API or internals well enough to say one way or the other, 
but there's no (mild) security concern here?  Like giving a potentially 
unsanitized string to GTK, or in the replacement routines of OString?

In any event, I've done as you suggested.  How does this round of the 
patch work?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-GTK-dialog-replacement-of-filename.patch.gz
Type: application/x-gzip
Size: 1063 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110224/34edc196/attachment.bin>

More information about the LibreOffice mailing list