[Libreoffice] [PATCH] Removed dependencies on tools/solar.h
kyoshida at novell.com
Mon Jan 3 20:36:08 PST 2011
On Mon, 2011-01-03 at 21:47 +0100, Soeren Moeller wrote:
> I have removed dependencies on tools/solar.h in some files in sc
> (according to http://wiki.documentfoundation.org/Easy_Hacks#write_tools.2F_pieces_out
> ) please review and commit.
BTW, we generally prefer the standard bool over sal_Bool, so I replaced
sal_Bool with bool in your patch. The only place we need to use
sal_Bool is when dealing with the UNO API. Other than that, the
standard boolean type is preferred.
Also, it's a bit weird to use sal_uIntPtr which isn't used much in our
code base. So I replaced that with sal_uInt32.
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida at novell.com>
More information about the LibreOffice