[Libreoffice] [PATCH] Removed dependencies on tools/solar.h

Caolán McNamara caolanm at redhat.com
Tue Jan 4 08:22:01 PST 2011

On Tue, 2011-01-04 at 10:11 -0600, Norbert Thiebaud wrote:
> 2/ the aforementioned problem  means that we would need to use
> sal_uIntPtr and not sal_uInt32 to convert ULONG, in order to maintain
> ABI.
> maybe we could wait for a major version boundary and officially define
> ULONG as uint32_t

I was talking originally about the sal_FOO types. Those are the ones
that are in the UNO ABI. You can fiddle with ULONG/LONG/SHORT/INT32/BYTE
etc all you like basically, those are not part of the exported UNO ABI
and fair game.

But ULONG is currently 64bits on 64bit unices, and 32bits on 32bit
platforms so globally changing them to sal_uInt32 will definitely break
something or other :-)

Joe's work to throw out the old Container/List etc. implementation
should hopefully remove a load of those ULONGs from the code-base for a
start anyway.


More information about the LibreOffice mailing list