[Libreoffice] [PATCH] installer::archivefiles - remove external find and chmod forks

Michael Meeks michael.meeks at novell.com
Fri Jan 7 08:15:53 PST 2011

Hi Steve,

On Mon, 2010-12-20 at 20:17 +1000, Steve Butler wrote:
> I just noticed my patch uses 0755 instead of 0775 as well - I'm not
> sure why you'd give group write access but that's what the original
> does.

	Apologies that this took so long to get reviewed and merged :-) I just
committed it. Whether it is truly useful or not, what is there must be
truly slow on Windows, which can't fork/exec anything in linear time :-)
[ and which is the only platform we do this on ]. Hopefully it'll speed
up the installer there.

	Thank you ! :-)

	It'd be great if you could perhaps clone / cut/paste part of the
relevant Easy Hack to the 'completed easy hacks' page, and/or its great
to have a statement saying the patch is LGPLv2+/MPL as you post it.

	Thanks again & what else are you interested in ? [ there is a lot of
low-hanging perl fruit in our make_installer world I think - simply
running it under a profiler and doing some optimisation would be highly
fruitful I think ].

	All the best,


 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list