[Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

Michael Meeks michael.meeks at novell.com
Wed Jan 12 03:52:44 PST 2011

Hi Noel,

On Wed, 2011-01-12 at 11:18 +0000, Noel Power wrote:
> fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is 
> riskless etc.

	wow - that is a surprising code flow :-)

> http://cgit.freedesktop.org/libreoffice/base/commit/?id=0afe2266016b03f6e11008463042c7daacead0e1
> is ripe for signoff and cherrypicking, be grateful if someone could help 
> with that

	100% - and we should re-work this in master to bin the:

	"global variable, initially set to zero that comes to hold a
	 fixed compile-time constant"

	pattern ;-)



 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list