[Libreoffice] [PATCH] unopkg crasher on SLED11-SP1 (bnc#655912)

Michael Meeks michael.meeks at novell.com
Fri Jan 14 01:23:53 PST 2011

Hi Petr,

On Thu, 2011-01-13 at 21:25 +0100, Petr Mladek wrote:
> could you please review the attached patch for libreoffice-3-3 branch? 

	Looks good to me; the method takes OUStrings, so there is no odd type
co-ercion (that I can see) going on.

> It looks like a compiler bug. I see it only on SLED11 with one
> particular gcc version. So, the solution is a kind of workaround but
> it should be fine in general. See the patch for more details.

	Personally, I don't believe we need such a huge block comment on this
(in master at least):

	// add temporaries to workaround gcc-4.3.4 specific bug

	would be fine for me - and (after long experience) I trust your
analysis of tangled compiler breakage :-) you have run the 'working' ie.
non gcc-4.3.4 version through valgrind to ensure that the bug isn't
there but hidden for some other reason ?

	Anyway, you have my vote.

	Thanks !,


 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list