[Libreoffice] (un)localized MSI installer [REVIEW REQUEST]

Michael Meeks michael.meeks at novell.com
Fri Jan 14 01:52:14 PST 2011

Hi Tor,

On Thu, 2011-01-13 at 14:18 -0700, Tor Lillqvist wrote:
> Which I did. Which was fun. Or at least entertaining.

	Great catch and analysis (and speed) :-) patch looks ok to me; though I
would prefer:

+    while ( nRet && ( nRet + 2 == rSize ) ) // buffer was too small, retry until big enough

	a >= instead of == rSize I think (being the paranoid
defensive I am).

	I also grokked all the other calls of GetPrivateProfileString git grep
showed me in the codebase, and in no other case do we have a similar
loop, and we usually pass in a 32k static buffer in those cases.

	So - lets get it in :-)

	Thanks !


 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot

More information about the LibreOffice mailing list