[Libreoffice] [PATCH] Unix 64 bits property type / default value mismatch

Lionel Elie Mamane lionel at mamane.lu
Mon Jan 17 06:18:48 PST 2011

On Mon, Jan 17, 2011 at 12:46:57PM +0000, Caolán McNamara wrote:
> On Sun, 2011-01-16 at 23:32 +0100, Lionel Elie Mamane wrote:

>> Another of those places in code the that assumes C long == 32 bit
>> integer. These four variables are used to give default values to
>> properties WindowTop, WindowLeft, WindowWidth and WindowHeight:

> Grepping for WindowTop in there, I see a LoadTableWindowData which
> apparently also reads those settings from a file as well and set
> them.  Given that there its also sal_Int32 types, I suggest that
> maybe its better to change the put to cast the input long type to a
> sal_Int32 instead ?

Well caught, I missed it. Well, we have to make these three places
agree. As to whether it is in the direction of "C/C++ long" everywhere
or in the direction of "uno long == sal_Int32" everywhere, frankly I
don't have enough overview / depth of knowledge into the codebase to
have an opinion.


More information about the LibreOffice mailing list