[Libreoffice] [PATCH] cursor vs scroll

[Andy Hearn]

Hullo,

I now think that this patch (identical to the "quasi" one sent a few days
ago) is the fix for my PostIt cursor vs scroll itch.

If I can quickly expand on this here.....

Grepping for all instances of "LayoutPostIts", turns out that it is called
by seven places throughout the entire project.

Applying pseudo-coding to get at a design perspective - to aid my
understanding:

sw/source/ui/uiview/viewport.cxx

LayoutPostIts called by OuterResizePixel

= when window changes, if postits visible, if cursor on a
postit, that postit must remain in view


sw/source/core/view/viewsh.cxx

by VisPortChanged

= when visual port changes, and if postits visible,
if cursor on a posit, that postit must remain in view


sw/source/ui/docvw/PostItMgr.cxx

Delete

= [n/a]

Delete [author notes overloaded version]

= [n/a]

Hide

= [n/a]

Show

= when postits first appear, i.e. on document load, cursor
is on document proper anyway.  otherwise, if postits
visible, if cursor on a postit, that postit must remain in view

CalcHdl [event handler]

= for whatever event we are interested in, if postits visible,
if cursor on a postit, that postit must remain in view.



Unless I've missed something more fundamental, IMHO the pseudo
code above makes little sense.


Removing the code by this patch gives us scrolling how it is for the
document proper.  (The postit containing the cursor is brought back to
view by the user typing on the keyboard/arrows as per elsewhere)

However I'm more than OK if this patch needs to be 'shelved' for now  :)

Cheers
Andy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110117/e54cec7f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cursor_v_scroll.patch
Type: text/x-patch
Size: 1580 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110117/e54cec7f/attachment-0001.bin>