[Libreoffice] REVIEW REQUEST: fdo#33088

Caolán McNamara caolanm at redhat.com
Tue Jan 18 05:46:15 PST 2011


On Tue, 2011-01-18 at 06:36 -0700, Tor Lillqvist wrote:
> Thorsten asked for an actual diff, so here:
> 
> diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx
> index e4e2716..e269766
> --- a/vcl/source/window/menu.cxx
> +++ b/vcl/source/window/menu.cxx
> @@ -1119,9 +1119,6 @@ void Menu::Highlight()
>          if ( pStartMenu && ( pStartMenu != this ) )
>              pStartMenu->aHighlightHdl.Call( this );
>      }
> -
> -    if ( !aDelData.isDeleted() && GetCurItemId() )
> -        GetpApp()->ShowHelpStatusText( GetHelpText( GetCurItemId() ) );
>  }

Yeah, got my vote for 3-3-0, nothing is connected up to that
ShowHelpStatusText and the help system has to iterate through all
extensions querying them for help on the item under the cursor when just
browsing through the menus, so its a fast amount of work to get
immediately thrown away.

I'd vote for straight forward removal on all branches.

C.



More information about the LibreOffice mailing list