[Libreoffice] NEW [PATCH] i#116187: report left/right page margin setting ignored on Unix 64 bit

Lionel Elie Mamane lionel at mamane.lu
Fri Jan 21 04:02:23 PST 2011

On Fri, Jan 21, 2011 at 09:39:07AM +0100, David Tardon wrote:
> On Fri, Jan 21, 2011 at 08:25:40AM +0100, Lionel Elie Mamane wrote:

>> FYI, the OpenOffice.org side fixed this in a way that seems more
>> robust to eventual future changes; you might want to push that way
>> into at least master (IMHO maybe not stable 3-3 branch, probably not
> 3-3-0).

> It is "robust" in the sense that SvxLRSpaceItem::QueryValue already
> performs cast to sal_Int32 if MID_L_MARGIN of MID_R_MARGIN member is
> requested.

I think the idea is:
QueryValue is defined in the class itself; so at the same place as the
variable (member) that actually stores the value. So its type changes,
one can better hope that the methods of the class are updated
accordingly, than code in a different module...


More information about the LibreOffice mailing list