[Libreoffice] [PUSHED] Re: NEW [PATCH] Unix 64 bits property type / default value mismatch
caolanm at redhat.com
Fri Jan 21 07:20:35 PST 2011
On Fri, 2011-01-21 at 11:01 +0000, Noel Power wrote:
> On 21/01/11 06:59, Lionel Elie Mamane wrote:
> > On Mon, Jan 17, 2011 at 04:58:28PM +0000, Caolán McNamara wrote:
> >> On Mon, 2011-01-17 at 15:18 +0100, Lionel Elie Mamane wrote:
> >>> (...) we have to make these three places
> >>> agree. As to whether it is in the direction of "C/C++ long" everywhere
> >>> or in the direction of "uno long == sal_Int32" everywhere, (..)
> >>> [no] opinion.
> >> Well, we have to assume from that LoadTableWindowData that the
> >> values may have been cached on disk somewhere, and have been
> >> assigned a data type of sal_Int32 for the purposes of file
> >> storage. So I say we use sal_Int32 everywhere for those four
> >> "long"s.
> > OK, here's the patch that changes the setters to sal_Int32 then.
> minor minor nit-pick, wouldn't it be better to use static_cast here ( at
> the very least that helps to grep for casts ) - and yes, I am guilty of
> not doing this too ( but I try to remember )
Tweaked the cast to be static_cast and pushed. Thanks for this.
We should get this into the stable branch as well if someone can give an
ack for this (cd83a62442883e9fc7fc3b489af7e9c7ff06b97c) and the other
related one (51a9333217687ff16df40ea3bd8983faaf5e425a) in base
More information about the LibreOffice