[Libreoffice] Duplicate entries in sd::ViewShellFactoryIds

Takeshi Abe tabe at fixedpoint.jp
Mon Jan 24 12:20:06 PST 2011


Hi,

Just out of curiousity, but I wonder why both IMPRESS_FACTORY_ID and
DRAW_FACTORY_ID share the same value 1 in impress/sd/inc/FactoryIds.hxx:
---
enum ViewShellFactoryIds
{
    IMPRESS_FACTORY_ID = 1,
    DRAW_FACTORY_ID = 1,
    SLIDE_SORTER_FACTORY_ID = 2,
    OUTLINE_FACTORY_ID = 3,
    PRESENTATION_FACTORY_ID = 4
};
---
At a glance they seems expected to be distinguishable
for, say, SdDLL::RegisterFactorys() in sd/source/ui/app/sddll1.cxx
or ViewShell::Implementation::GetViewId() in
sd/source/ui/view/ViewShellImplementation.cxx .
Any suggestions would be appreciated.

Cheers,
-- Takeshi Abe


More information about the LibreOffice mailing list