[Libreoffice] [PUSHED] Re: cppcheck patches

[Caolán McNamara]

On Mon, 2011-01-24 at 09:15 +0000, Andy Holder wrote:
> Here are some patches removing unused variables found by cppcheck

Looks good, thanks for these, pushed.

As an aside, there's always a fear in reading these that something like

foo unused = doSomething();

where "unused" is unused gets the entire line removed where

doSomething();

might be the right fix instead. i.e. we still want doSomething, but
don't care about to return value anymore

Though in these cases (0001-cppcheck-unused-variables-writer.patch
0001-cppcheck-Variables-not-used-filters.patch and
0004-ccpcheck-unused-variable-filters.patch) all the methods whose
return value is unused and whose calls are removed by these patches
appear to have no side-effects, so applied.

C.