[Libreoffice] [PATCH] remove unused declaration - an unlikely fix for armel segfault in regcomp

Jani Monoses jani at ubuntu.com
Thu Jan 27 10:13:20 PST 2011

On 01/27/2011 05:31 PM, Caolán McNamara wrote:
> On Thu, 2011-01-27 at 15:42 +0200, Jani Monoses wrote:
>> armel
> sal/osl/unx/interlck.c probably should have a specific impl for arm btw,
> probably a low hanging fruit for someone who knows a little bit of arm
> assembly.

What about using GCC atomic builtins like in the attached patch?

If correct (seems so, but I did no test it beyond building it - are
there tests for this in LibO?) it has the advantage of covering more
than ARM, and for ARM letting gcc emit optimal (I hope) code by
taking care of differences between atomic exchange primitives on ARM pre
v6 (SWP) and newer (STREX/LDREX) and memory barrier instructions
(DMB vs MCR ....). Debian still builds for armv5 while Ubuntu for armv7
so there would have been at least some ifdefs if assembly were used.

IMHO it is better to stick to portable C/C++ if it does not constitute a
drawback otherwise :)


More information about the LibreOffice mailing list