[Libreoffice] [PUSHED, partial] Re: [PATCH] removed bogus comments

Caolán McNamara caolanm at redhat.com
Fri Jan 28 03:32:48 PST 2011


On Thu, 2011-01-27 at 04:08 +0900, Suguru Hirahara wrote:
> Hello,
> 
> other two patches are attached. There were just bogus comments removed.
> (LGPLv3+ / MPL)

So I pushed a good chunk of this, but not all, because while comments
that indicate the date and author of a change are not really useful and
should go, the catch is that the format "#iXXXX" refers to the public
OpenOffice.org bug tracker id XXXX and is a useful piece of information,
e.g.

-//CMC 2008-02-14 #i53420# some text
+//some text

is better done as 

-//CMC 2008-02-14 #i53420# some text
+//#i53420# some text

With the exception that #XXXX# or b#XXXX# refers to the Hamburg private
bugtracker or Sun internal bugtracker and isn't a useful piece of
information, e.g.

-//CMC 2008-02-14 #53420# some text
+//some text

is good in that case.

Thanks for this.

C.



More information about the LibreOffice mailing list