[Libreoffice] [PATCH] EasyHacks 4.13 - get rid of macros from svarray.hxx
kyoshida at novell.com
Fri Jan 28 07:57:19 PST 2011
On Fri, 2011-01-28 at 10:50 -0500, Kohei Yoshida wrote:
> Thanks for your patches.
Oh yeah, I almost forgot. ;-)
You don't need to remove all trailing whitespaces in those files you
modify, as that would create unnecessary hunks making it harder for us
to review your patches.
I thought that it was our aggressive commit hook that did this, but
talking to Miklos on IRC made it clear that the commit hook as of
November only fixes modified lines.
Also, if you are up for it, writing a unit test code in
sc/qa/unit/ucalc.cxx is a great way to ensure that your change does not
accidentally change the behavior of the application. I don't want to
make this a requirement for all patch submissions, but writing a unit
test code along with your code change would give the patch reviewers a
great piece of mind. :-)
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida at novell.com>
More information about the LibreOffice