[Libreoffice] [PATCH] GTK: remove menu when we press the alt key
michael.meeks at novell.com
Fri Jan 28 09:16:00 PST 2011
On Fri, 2011-01-28 at 16:50 +0100, xapantu wrote:
> Here is a patch to remove the menu when the alt key is pressed, it is
> not the case with GTK apps, and is disturbing. And the code to show the
> menu wasn't at the right place, so, even if we should have this menu, it
> is dirty IMO.
Fair enough :-) I suspect this was some attempt to have a windows like
behaviour - whereby pressing alt just once would give you keyboard focus
into the menu-bar; and another time - you would get the menu pop-down.
OTOH - no other gtk+ app works like that, so we bin it.
Don't you love the 'deletion listeners' around the place - instead of
having reference counting on VCL widgets ;-)
> PS: this time, I used git format-patch, tell me if there is any problem.
Beautiful, saved time review it; though you missed the
LGPLv3+/MPL message ;-)
I also cleaned out the (now unused) m_bSingleAltPress.
michael.meeks at novell.com <><, Pseudo Engineer, itinerant idiot
More information about the LibreOffice