[Libreoffice] [PATCH] refactoring gendict

[Kenneth Venken]

Hi,

i came across gendict.cxx while fixing a possible memleak. It took me some
time to figure out what the code did.
I notice a lot of very very long function bodies in LO-code, gendict was no
exception. So i refactored the code, did some google searches on gendict and
was able to fix the memleak.
I ended up submitting only the fix, not the refactoring, because i didn't
want to break any de facto coding style guideliness and i am still a fairly
new contributer to LO.

I submit these patches now, so you guys can decide if you push them or not.
In case it could save some other new contributor some time in understanding
gendict ;)
BTW, i tested the code on ja.dic and output is still the same.

-- Kenneth
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110130/adadb9e0/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-added-some-documentation-to-gendict.patch
Type: text/x-patch
Size: 1531 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110130/adadb9e0/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-refactored-out-some-simple-print-functions.patch
Type: text/x-patch
Size: 2995 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110130/adadb9e0/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-refactored-out-dataArea.patch
Type: text/x-patch
Size: 5203 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110130/adadb9e0/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-refactored-out-all-array-functions.patch
Type: text/x-patch
Size: 8621 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110130/adadb9e0/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-reduced-scope-of-some-variables.patch
Type: text/x-patch
Size: 5205 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110130/adadb9e0/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-readability-changes.patch
Type: text/x-patch
Size: 7922 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110130/adadb9e0/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-changed-some-loop-constructs.patch
Type: text/x-patch
Size: 1794 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110130/adadb9e0/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-more-comments.patch
Type: text/x-patch
Size: 4804 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110130/adadb9e0/attachment-0015.bin>