[Libreoffice] [PUSHED] Re: [PATCH] Cpp Cleanliness: unread variable

Caolán McNamara caolanm at redhat.com
Sun Jan 30 13:34:25 PST 2011

On Sun, 2011-01-30 at 01:11 +0100, Kenneth Venken wrote:
> hi,
> this removes unread variable pTargetPage
> from ./impress/sd/source/core/drawdoc2.cxx

It does, but do we know for a fact that it should be

-pTargetPage = GetSdPage(nPage, PK_STANDARD);
and not 
-pTargetPage = GetSdPage(nPage, PK_STANDARD);
+GetSdPage(nPage, PK_STANDARD);

i.e. it might be that GetSdPage has some vital side-effects and that the
call should remain, and only the return value should be discarded.

Anyway reading through it, SdDrawDocument::GetSdPage is defined as a
const method, so it *claims* to have no side-effects, though it calls
into some stuff that creates the page on demand apparently, though
there's already another call in the ::MovePages function being changed
that goes through the same on-demand loader, so yeah, the patch *surely*
is the right one :-)

Thanks for this, now pushed.


More information about the LibreOffice mailing list