[Libreoffice] [REVIEW] LibreOffice does not produce valid DOC documents

Jan Holesovsky kendy at suse.cz
Fri Jul 1 01:18:58 PDT 2011


Hi Cedric, all,

https://bugs.freedesktop.org/show_bug.cgi?id=37516

So this one was a particularly nasty one; the only thing I had was a
black box (in the form of MSO 2010) answering yes/no about the document
validity :-)  Long story short, it was SPRM SDxtCharSpace that had wrong
value.

The attached patch reverts the simplified computation of its value that
produces wrong results when nPitch is smaller than nPageCharSize.  Maybe
it could be simplified in another way, but I think the safest ATM is to
return to the algorithm that was there before (see commit
e5693d5e14f8a53070b86ea1682201f5f2149b82).

Review appreciated, targeting libreoffice-3-4 branch.

Thank you,
Kendy


More information about the LibreOffice mailing list