[Libreoffice] [REVIEW] Fix losing changes in a table in writer

Cedric Bosdonnat cedric.bosdonnat.ooo at free.fr
Fri Jul 1 09:26:55 PDT 2011


Hi Kendy,

On Fri, 2011-07-01 at 16:43 +0200, Jan Holesovsky wrote:
> In the document attached to the bug, when you copy the described table,
> do edits there, and save it as .doc, the changes are lost.  These are in
> fact 2 bugs, but I fixed the more serious one.  One is that when you
> copy/paste a fieldmark, the essential attributes are not preserved;
> later, when saving, the fieldmark is of unknown type, and ignored.  We
> should save even the unknown fieldmarks I think, but here I fixed the
> root cause - that the attributes are not copied.

The patch is ok to me, but for completeness we should copy the
GetParameters map too. Could you please review my changes for this?

> Patch attached, please sign-off, and push to libreoffice-3-4.

I pushed it... but forgot to sign it off.

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr


More information about the LibreOffice mailing list