[Libreoffice] [REVIEW] Debug-mode getline-using sal unittest crashes, triggered by _GLIBCXX_DEBUG
Julien Nabet
serval2412 at yahoo.fr
Fri Jul 1 09:59:58 PDT 2011
Le 30/06/2011 14:26, Nigel Hawkins a écrit :
> On Wed, 2011-06-29 at 23:26 +0200, Julien Nabet wrote:
>> diff --git a/sal/qa/osl/process/osl_process.cxx
>> b/sal/qa/osl/process/osl_process.cxx
>> index 2535c4c..8695d79 100644
>> --- a/sal/qa/osl/process/osl_process.cxx
>> +++ b/sal/qa/osl/process/osl_process.cxx
>> @@ -477,6 +477,7 @@ public:
>> );
>>
>> std::string line;
>> + line.reserve(10000);
>> while (std::getline(file, line, '\0'))
>> env_container->push_back(line);
>> tidy_container(*env_container);
> That change fixes the problem here.
Hello,
Can i push this patch as a workaround or do you think about a better
solution ?
Julien
(FYI : I won't be there for 2 weeks from tonight)
More information about the LibreOffice
mailing list