[Libreoffice] [PATCH] fix for fdo#30800: Option to display calc gridlines on colored cells

[Katarina Machalkova]

Hey there, 

> this is a patch to fix fdo#30800.
> 
> A tiny specification, what has been implemented is at the wiki:
> http://wiki.documentfoundation.org/User:Andreschnabel/Spec_Calc_grid_lines_
> on_colored_background
> 
> Comments and questions are welcome, as this is the first time that I
> actually *add* some code.

Well done! Attached is a small modification to the code (and the function) 
I've made. I.e. it makes sense to allow user to define grid colour (and thus 
enable fixed text & related listbox) in both cases when the grid is enabled -- 
in both "show" and "show on colored cells" case.

Also, before I really push the patch -- may I suggest some change to the 
wording being used? 
"Show on colored cells" sounds sliiiightly misleading to me, as the grid is 
shown everywhere (all over the sheet), not only over the cells filled by some 
colour. Something along "Show always on top" or "Show in the foreground" line 
would imao describe its function much better ... Consequently, the option name 
would become GridOnTop, or GridInForeground, but that's just nitpicking ...

B.
-- 
  \\\\\              Katarina Machalkova    
  \\\\\\\__o          LibO developer
__\\\\\\\'/_          & hedgehog painter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: display-grid-lines.diff
Type: text/x-patch
Size: 902 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110704/318f9041/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110704/318f9041/attachment.pgp>