[Libreoffice] Do we still need to support non-XKB X11 systems ?

[Michael Meeks]

Hi Francois,

On Fri, 2011-07-08 at 08:10 +0200, Francois Tigeot wrote:
> The file libs-gui/tools/inc/tools/prex.h tries to detect the presence of
> the X11 keyboard extension (XKB) in a completely bogus way - by hardcoding
> a value depending on the operating system it is build for:

	Lol ;-)

>   // FIXME: should really check for xfree86 or for X11R6.1 and higher
>   #if defined(LINUX) || defined(FREEBSD) || defined(MACOSX) || defined(NETBSD) || \
>       defined(OPENBSD) || defined(DRAGONFLY)
>   #define __XKeyboardExtension__ 1

	So - reading the above it really looks like an:

#ifndef defined(SOLARIS)

	which is somewhat odd, since it should have XKB too.

> Now, I could try to use something less brain damaged to detect the presence
> of the XKB extension but it has been part of X since X11R6.1 which has been
> released in March 1996 ...

	Lets kill that :-)

	ATB,

		Michael.

-- 
 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot