[Libreoffice] [REVIEWED] + Cherrypick request for 3.4.2

Muthu Subramanian K sumuthu at novell.com
Mon Jul 11 04:51:28 PDT 2011


Hi,

Thank you!
> 
> 	This sort of stuff:
> 
> +    if( bShowValue &&
> +        !bShowPercent && rTypeInfo.meTypeCategory == TYPECATEGORY_PIE &&
> +        rDataLabel.maNumberFormat.maFormatCode.indexOfAsciiL("%", 1) >= 0 )
> +    {
> +        bShowValue = false;
> +        bShowPercent = true;
> +    }
> 
> 	makes me wonder if we don't want that in our own pie chart
> implementation rather than in the filter though ... :-) But I picked it
> for -3-4.
Sorry, but I didn't understand this. Did you mean the filter code (oox),
please?

> 
>> http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=7589a8d3f6d3cb9f08f39059dedf05b7636cbc0f
> 
> 	Picked for 3-4 - though I'd be interested to know who needs to read
> these later.
fdo#36733: LO creates a temp' file and then reopens this for editing.
So, files with permission something like 066 would fail to open on LO.

Thanks again!
Muthu Subramanian


More information about the LibreOffice mailing list