[Libreoffice] error in basic.src ?

[Matúš Kukan]

On 16 July 2011 22:27, Andras Timar <timar74 at gmail.com> wrote:
> Hi Matus,
>
> 2011.07.16. 21:40 keltezéssel, Matúš Kukan írta:
>> So, I guess It's wrong in basic.src and there should be something else
>> or maybe whole IDD_TT_ABOUT_DIALOG is unused.
>> Or it shall be there and we want to define that also when using new
>> build system?
>
> It is not used in the main LibreOffice product but in the VCLTesttool
> utility. As we no longer use the master workspace + milestone concept, I
> think the build ID should be there as in
> http://opengrok.libreoffice.org/xref/components/cui/source/dialogs/about.cxx#77
>
It seems to be unused also in VCLTestTool. At least I could not grep
aVersionString from
http://opengrok.libreoffice.org/xref/libs-core/basic/source/app/dialogs.cxx#67
anywhere.
So maybe something like attached patch could be pushed.
Someone willing to review and push?

Regards,
Matus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Get-rid-of-unused-RID_VERSIONSTRING.patch
Type: text/x-patch
Size: 2459 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110716/32793af5/attachment.bin>