[Libreoffice] [PATCH] Work around a bash-ism in configure.in

Tor Lillqvist tlillqvist at novell.com
Mon Jul 18 22:21:57 PDT 2011


> So as long as the OS check is first, we don't evaluate $EUID except on Cygwin.

But it wasn't as such the existence or not of $EUID that was the problem here, was it? The problem was the use of -eq operator when the left-hand side of the operator, "$EUID" , was an empty string and thus not a number, no?

BTW, the "z" prefixes that Michael added are not needed. Surely all modern shells (or standalone test commands) handle   test "" = 0   just fine. The convention to avoid nonempty arguments to test is just hypercorrectness by now. (For any platform where one would seriously consider building LibreOffice, at least.) The configure.in script uses   test "$foo" = ""   already.

--tml




More information about the LibreOffice mailing list