[Libreoffice] [REVIEW] Fix for fdo#39236

[Kohei Yoshida]

Hi there,

I'd like to have the following commit

http://cgit.freedesktop.org/libreoffice/calc/commit/?id=8da78944e7c4fcae9ae40bea7162898d20db6329

cherry-picked to -3-4 and -3-4-2 in order to fix

https://bugs.freedesktop.org/show_bug.cgi?id=39236

which is a nasty crasher which took me almost a full day to figure
out. :-/

In the end, it was because of my mis-use of the remove-erase idiom to
remove elements from ptr_vector, which caused double-delete.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida at novell.com>