[Libreoffice] [REVIEW 3.4] FindBar silently reuses options from the Search & Replace dialog

[Kohei Yoshida]

Hi Kendy,

On Wed, 2011-07-27 at 00:51 +0200, Jan Holesovsky wrote:

> With the patch I am proposing for cherry-picking to 3.4 (I have pushed
> that to master), the options are unset when you use the FindBar, ie. it
> resets whatever flags the user has set in the Search & Replace dialog
> too.  This is not easy to fix, so I wonder if you consider this stop-gap
> solution bearable for the users?

So, this is a tough call, but I'm *personally* not in favor of putting
this to 3.4 because, to me, this would only replace one quirk - re-using
the options from the find replace dialog when doing the find bar search,
with another one - resetting the options when the user does find bar
search, which would also reset the options in the find replace dialog.

Also, after testing this on master, the similarity search option doesn't
get reset even after the find bar usage while all the other options do
get reset.  So, the changed behavior feels a bit more weird than the old
one (to me).  I would much rather we keep the current behavior over the
new one for 3.4, while trying to fix this the right way on master.

BTW, we do have similar issues with the CSV import options dialog, which
we happen to re-use for Data - Text to Columns.  Over there, we
(somehow) manage to retain the options set in the CSV import while using
a pre-defined set of options for the Text to columns operation, without
having them interfere with each other.  Perhaps we could do something
similar with the find bar / find replace dialog code while fixing on
master.

Having said all this, I'm just one developer, and this is just my
personal opinion.  And I would be interested to hear from other folks as
well.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida at novell.com>