[Libreoffice] [REVIEW] fix for fdo#37584

John LeMoyne Castle lemoyne.castle at gmail.com
Wed Jun 8 08:54:00 PDT 2011


Cedric, 
I apologize for the time cost for you to dig this up.  

I do remember removing a string copy (or maybe two?).  I should have clearly
seen the need for a full copy after digging into the counting process and
seeing the changes it made to the string in order to count excluding hidden
or redlined,  Definitely my bad for not testing more use cases (redlining). 
I will go back and review my work in this area.  

I see that this is marked as a regression against 3.3.2 and yet the word
count work was well over 6 months ago.  
I had thought that word count w/ and w/out spaces had rolled out prior to
3.3.2   
Perhaps the problem exists (undiscovered) in 3.3.2 as well.

jlc

--
View this message in context: http://nabble.documentfoundation.org/REVIEW-fix-for-fdo-37584-tp3038258p3039644.html
Sent from the Dev mailing list archive at Nabble.com.


More information about the LibreOffice mailing list