[Libreoffice] [PUSHED] Patch for fdo#32786

[Norbert Thiebaud]

On Wed, Jun 8, 2011 at 5:32 AM, Samuel Mehrbrodt
<s.mehrbrodt at googlemail.com> wrote:
> Hi,
>
> When I wanted to commit, git complained about remaining tabs and so I
> also replaced them with spaces. That makes the patch look bigger than it
> actually was, but I didn't see another way.

You could have edited the patch afterward to remove the un-needed section...
that is easier done with a patch-aware editor, like emacs (and most likely vim)
But in thta case, all that was needed was to remove the chunk that
were just tab/whitespace related
for reference : here is the edited version... which applied cleanly.

>
> The actual changes in the patch are in line 20 (import) and from line
> 580 down (removed lcl_TransliterateEditEngine and changed
> ScDocument::TransliterateText).
>
> This is my first contribution to LO, so I'm open for your feedback :)

First: Welcome aboard :-)

Second, few remarks, feedback.

It would be great if:
* you added In the subject use [PATCH] (with the bracket and the
capitalization... that help us spotting these :-)
* you indicate that you build the patched version
* you indicate what you did if any to verify the resolution of the bug.

So, I tweaked the patch to remove the space/tab chunks, applied it and
run test test scenario in fdo#32786.
It works fine...
I did not reproduce the bug _before_ applying the patch (not that I
couldn't reproduce, but I did not - shame on me :-) )

in any case: Pushed to master, and I closed the bug..

Thanks again.

Norbert


>
> [1] https://bugs.freedesktop.org/show_bug.cgi?id=32786
> [2] http://hg.services.openoffice.org/OOO340/rev/de0464b37fb3

These links above were very useful, thanks, keep doing that :-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-for-fdo-32786-Capitalise-Every-Word-function.patch
Type: application/mbox
Size: 9185 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110608/1d2baa37/attachment.bin>