[Libreoffice] [REVIEW] Fix for fdo#37673

Kohei Yoshida kyoshida at novell.com
Wed Jun 8 21:26:08 PDT 2011


Here is another fix for review.

http://cgit.freedesktop.org/libreoffice/calc/commit/?id=4820648fc4abe7984c3c3c35e4c727c5574e8939

This one fixes the following crasher

https://bugs.freedesktop.org/show_bug.cgi?id=37673

which BTW happens only on Windows.  The reason for the crash is that the
pTableMap pointer passed to ScHTMLTableIterator can be NULL sometimes,
and when it's null, the two iterator data members will be left
un-initialized.  When the is() method is called under such
circumstances, those un-initialized iterators get accessed, which
somehow causes crash on Windows.

I'd like to have this cherry-picked to the -3-4 branch.  Review
appreciated.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kyoshida at novell.com>



More information about the LibreOffice mailing list