[Libreoffice] [PATCH] Bug 33293 - [EasyHack] Make starting count of worksheets configurable

Albert Thuswaldner albert.thuswaldner at gmail.com
Fri Jun 10 13:34:39 PDT 2011


Hi,
It took some time to fix this. I moved stuff to a new computer, had
some build problems, implemented some changes (see below), and had a
fair share of bugs to straighten out. But now I think I'm finished
with this feature patch. Please have a look

- Changed the option tab page to defaults.
- Changed the name of the handler class to ScTpDefaultsOptions
- Changed the type of the tab enumerator to SCTAB
- Changed to c++ type static casts
- Renamed variables to more sensable names
- Added new option nodes in
officecfg/registry/schema/org/openoffice/Office/Calc.xcs
- Set the maximum allowed sheet tabs tat you can enter into the input
field to 32000

I also looked at checking that no negative numbers/character are
inserted. To my understanding, you don't have to to anything special,
it is taken care of in the input field. If you try to give a negative
value as an input it changes to the minimum value (in this case  have
been setting this to 1) and the same happens when you try to enter a
character. This is also consistent with how other input fields behave.

Regards,

/Albert

On Wed, Jun 1, 2011 at 16:15, Kohei Yoshida <kyoshida at novell.com> wrote:
> Sorry I forgot to snip a large part of it.  Don't copy this behavior of
> mine... It's something to be used as a counter-example of good
> behavior. ;-)
>
> Kohei
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: start-count-worksheets9.diff
Type: text/x-patch
Size: 22731 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110610/7af3cbe7/attachment-0001.bin>


More information about the LibreOffice mailing list