[Libreoffice] [REVIEW] fdo#38154: Invalid xls export of docs with split/frozen window

Katarina Machalkova kmachalkova at suse.cz
Mon Jun 13 05:18:15 PDT 2011

Hey folkzz,

can some1 please review attached patch that fixes the following bug: 
https://bugs.freedesktop.org/show_bug.cgi?id=38154 ? If spreadsheet file 
contains split/frozen window,  LibO exports invalid xls, causing Excel to pop-
up an error and open the file in protected (read-only) mode, which sucks.

It's some fallout from increasing Calc's row limit above 65k lines ( 
interesting commits: 2e404645, 252d25a1, 26d84b51 ), where the internal 
variable holding row no. became 32-bit instead of 16-bit integer. However, all 
32-bit ints must be converted back to 16-bit ones on binary export. In this 
particular scenario (doc with split/frozen window) Y coordinate of the split 
was still exported as 32bit, which was obviously wrong.

Note that just the 1st hunk is sufficient for fixing the binary export, the 
rest is there for the sake of consistency and unified handling of variables 
holding the row number on import & export.


  \\\\\              Katarina Machalkova    
  \\\\\\\__o          LibO developer
__\\\\\\\'/_          & hedgehog painter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fdo-38154-convert-split-win-Y-coord-to-16bit-int-bef.patch
Type: text/x-patch
Size: 3063 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110613/2e277fde/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110613/2e277fde/attachment.pgp>

More information about the LibreOffice mailing list