[Libreoffice] Duplicate code: hwpreader.cxx

Caolán McNamara caolanm at redhat.com
Tue Jun 14 02:04:13 PDT 2011


On Wed, 2011-06-08 at 21:19 +0200, Chr. Rossmanith wrote:
> Hi,
> 
> I've found a .hwp document here 
> http://openoffice.org/bugzilla/show_bug.cgi?id=31091, tried to open it 
> but only get a blank page - no error message. Where would I start to 
> analyze what's going wrong? If hwpfilter is not working, maybe it's no 
> use to improve the code...

There are two .hwp files there, one old format 3.0 which does work,
eventually anyway, and one (I think new format) that doesn't.

There wasn't a typedetection implemented for that filter to make it do
the right thing automatically. So I quickly stuck one in there to detect
the supported formats, so the "hangul97-3.0.hwp" example should work out
of the box now.

So I gbuildized hwpfilter, added correct typedetection and a cppunit
test to ensure that "hangul97-3.0.hwp" remains working.

C.



More information about the LibreOffice mailing list